Is the web terminal error also fixed?
I’m wary of updates now. The changelog only shows three bugs fixed. But there are more.
New bug.
The Database Creation tab doesn’t show which prefix will be added - Prefix %s will be automatically added to the Database and its user.
How can I fix this?
Edit /usr/local/hestia/web/templates/pages/add_db.php and replace this:
$prefix_hint = tohtml(_("Prefix %s will be automatically added to database name and database user"));
with this:
$prefix_hint = _("Prefix %s will be automatically added to database name and database user");
Yes, it worked. It’s a shame that happened. I hope it gets fixed globally.
I updated one of the servers for testing.
It’s too bad that most of the fixes aren’t included in the updates at all.
Another problem: for some reason, the default language in the file manager is English, not the default language set for the account.
==
I solved the problem.
For some reason, the /usr/local/hestia/web/fm/configuration.php file changed. It’s incorrect after the update.
use function Hestiacp\quoteshellarg\quoteshellarg;
if (session_status() === PHP_SESSION_ACTIVE) {
session_write_close();
}
$dist_config = require __DIR__ . "/configuration_sample.php";
$dist_config["public_path"] = "/fm/";
changed to:
use function Hestiacp\quoteshellarg\quoteshellarg;
$dist_config = require __DIR__ . “/configuration_sample.php”;
session_start();
$dist_config[“public_path”] = “/fm/”;
==
I ask the developers to make global changes.
=======
I see that the respected @sahsanu made fixes a long time ago: Fix: prevent session conflict in File Manager configuration by sahsanu · Pull Request #5286 · hestiacp/hestiacp · GitHub
But no one even included them in the update. I don’t want to get into a fight with anyone, but why don’t the developers include these fixes? The same problems keep popping up after updates. They’ve already been fixed; just enable all the fixes!
Here’s what else I found in the logs:
FastCGI sent in stderr: “PHP message: PHP Warning: Undefined array key “LC_MESSAGES” in /usr/local/hestia/web/inc/i18n.php on line 36; PHP message: PHP Warning: Trying to access array offset on null in /usr/local/hestia/web/inc/i18n.php on line 36; PHP message: PHP Warning: Undefined array key “LC_MESSAGES_locale” in /usr/local/hestia/web/inc/i18n.php on line 36; PHP message: PHP Warning: Trying to access array offset on null in /usr/local/hestia/web/inc/i18n.php on line 36” while reading response header from upstream, client: 93.ХХХ.ХХХ.ХХХ, server: _, request: “GET /edit/user/?user=хххх&token=ff069d7567fd805af1a750dda6f14c1d HTTP/2.0”, upstream: “fastcgi://unix:/run/hestia-php.sock:”
I’ve already added a pull request before you. But it doesn’t matter who’s first or second.
The main thing is that the global update finally includes all the changes, and everything will be fine. Releasing one update at a time and then fixing what’s already fixed doesn’t seem right.
Ohh. I did not see that, and did not realise you would have done that. Usually you put the MR details here. So I thought you did not.
I’m interested in the panel working properly. The developer only needs to release an update with all the changes contributed by community members, and everything will be fine. All the changes have already been tested and are working correctly.
==
Almost as soon as I find a problem, I write about it here.
I’d appreciate it if you stopped saying that.
With that “fix” you will get again this error:
"PHP message: PHP Warning: ini_set(): Session ini settings cannot be changed when a session is active in /usr/local/hestia/web/fm/vendor/symfony/http-foundation/Session/Storage/Handler/NativeFileSessionHandler.php on line 53" while reading response header from upstream
I’ll create a PR to fix it, please test the fix:
<?php
use function Hestiacp\quoteshellarg\quoteshellarg;
if (session_status() === PHP_SESSION_NONE) {
session_start();
}
$lang = $_SESSION["language"] ?? $_SESSION["LANGUAGE"] ?? "en";
session_write_close();
$dist_config = require __DIR__ . "/configuration_sample.php";
$dist_config["public_path"] = "/fm/";
The PR that changed that file also modified many other files. Did you check whether more changes are needed? Because in that case, it doesn’t make sense to open a PR for every file.
The web terminal issue still hasn’t been fixed with the update.
/usr/local/hestia/web-terminal/web-terminal-session-auth.php still hasn’t appeared…
Yes, we know it, you said it a few times. There is an open issue, be patient.
Could you please test the fix I posted above and give me feedback?
I’ve already tested it and everything works perfectly. Your changes are working. Thank you!
I am very interested in everything in the panel working as it should!
Me too.
Have you submitted a pull request yet?
It’s really unclear to me that so many changes have been made, but in the end they simply don’t make it into the update!
Nope. I’ll do it tonight. I also want to fix an issue with LC_MESSAGES that I saw in the logs when accessing the user config.
Please advise on ways to solve the problem. Thank you