Backups are not overwritten

Nameless · March 10, 2023, 11:38am

Hi! I found out if you make the available number of backups more than 1, then these backups are not overwritten, you need to delete the extra ones yourself. It would be convenient to be able to automatically overwrite the earliest copy. Also, only 1 backup is available for the administrator account, is this how it is intended?

eris · March 10, 2023, 12:00pm

it should over written the oldest backup by default when it reaches the max number of backups

Nameless · March 10, 2023, 2:09pm

does not overwrite, even if you enter a command in the console

eris · March 10, 2023, 3:39pm

Please provide with a log file?

Nameless · March 15, 2023, 5:12am

I found that the log is stored only for the last day. So I did an experiment. Deleted all backups. And I took a screenshot of the log for every day. Now there is a setting for the maximum number of backups equal to 3 pieces. The screenshots show that there are copies for the last 3 days, but there is no copy for today, there is a copy for the admin user.

Summary

Скриншот 15.03.23_08.05.37

eris · March 15, 2023, 6:36am

github.com

hestiacp/hestiacp/blob/03711ec798ded24e7da8b4cb6d9429c2ddfcb9fe/bin/v-backup-user#L772-L776


      
          # Removing old backups
          tail -n $BACKUPS $USER_DATA/backup.conf > $USER_DATA/backup.conf_
          mv -f $USER_DATA/backup.conf_ $USER_DATA/backup.conf
          chmod 660 $USER_DATA/backup.conf
          chmod 660 $BACKUP/$user.log

Is removeing the oldest backup from backup.conf

Deletes the oldest backup from the server

github.com

hestiacp/hestiacp/blob/03711ec798ded24e7da8b4cb6d9429c2ddfcb9fe/func/backup.sh#L21-L27


      
          		# Removing old backup
          		for backup in $(echo "$backup_list" | head -n $backups_rm_number); do
          			backup_date=$(echo $backup | sed -e "s/$user.//" -e "s/.tar$//")
          			echo -e "$(date "+%F %T") Rotated: $backup_date" \
          				| tee -a $BACKUP/$user.log
          			rm -f $BACKUP/$backup
          		done

eris · March 15, 2023, 6:53am

Also trigger v-backup-user user to see what it does…

Nameless · March 15, 2023, 3:11pm

and where is the file located backup.sh ?)

maurice · March 15, 2023, 4:30pm

basic skills:
find / -iname *backup*

Nameless · March 21, 2023, 2:57pm

Compared the files, they are identical, except for this place, made a replacement, did not help

eris · March 21, 2023, 3:05pm

Without any kind if logs I really can’t debug … As I am not able to replicate the issue on my own server…

Nameless · March 21, 2023, 3:20pm

Here you can see that the last backup was created on the 18th and was no longer overwritten.

eris · March 21, 2023, 3:37pm

No new back up has been made either…

Run v-backup-user user