BUG: Raw HTML entities (., =) displaying in UI and breaking "Login as" links (v1.9.6)

21

I lied. I ended up investigating it further :stuck_out_tongue:

To fix it, edit /etc/hestiacp/hooks/pluginable.php and add this line:

$html = html_entity_decode($html, ENT_QUOTES | ENT_HTML5, 'UTF-8');

Before this line:

$dom->loadHTML( $html );

If you don’t want to edit it manually, execute this sed command:

sed -i.bak 's/\$dom->loadHTML( \$html );/\$html = html_entity_decode(\$html, ENT_QUOTES | ENT_HTML5, '"'"'UTF-8'"'"');\n\t\t\$dom->loadHTML( \$html );/' /etc/hestiacp/hooks/pluginable.php

Remember to restore the change you did in function tohtml in /usr/local/hestia/web/inc/helpers.php.

22

Hi @sahsanu, I owe you a massive apology. I have to eat my words here: you were 100% right all along.

I completely forgot that about a year ago, I installed the hestiacp-pluginable framework just to test a node app and left it there. I genuinely thought I was running a completely clean, vanilla server.

Once I checked /usr/local/hestia/plugins/, there it was. The plugin framework was intercepting the pages, and its old code was failing to process the new ENT_HTML5 flag in Hestia 1.9.6, which is what caused the = and . bug.

I just ran the plugin’s uninstaller, cleared the hooks, rebuilt my web domains, and… magic. Everything works perfectly on the native 1.9.6 update without any manual patches to helpers.php.

I am really sorry for the pushback and for sending you on a wild goose chase. Thank you for your patience and for nailing the exact cause even when I stubbornly insisted otherwise.

Thanks for all the hard work you guys do on Hestia! Case closed. :clinking_beer_mugs:

23

There is no need to apologize. I understand that if something doesn’t work after updating Hestia, you might think that Hestia is the problem :wink:

24

Your solution fixed the same problem I was having.

Thanks you!

25

You’re welcome but double check it because I think that clicking on Advanced options button doesn’t work.

26

indeed it broke the Advanced options button. :confused: Do you have a fix for that?

27

Nope, I don’t have a fix. But the way that plugin works, hijacking Hestia pages will never end well.

28

I see, I will remove it. Do you know if there is a away to run NodeBB without the plugin?