Customs Templates must be included in backup

trogvar · November 18, 2022, 10:08pm

Moved several servers today and noticed that custom Web templates that I wrote are missing after restore. They stored in /usr/local/hestiacp/data/templates/web/nginx.
So I checked - there are not included at the backups.
May be some folder should be created in users home for custom templates?

eris · November 19, 2022, 12:03am

The templates should be include in the backup it self. It is currently not activate or restored…

eris · November 19, 2022, 1:07am

github.com

hestiacp/hestiacp/blob/5965a75a54cb0a670b26d3329ca82628875033ae/bin/v-backup-user#L276-L335


      
          # Backup vhost config
          if [ -e "$HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.conf" ]; then
              cp $HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.conf* conf/
          elif [ -e "$HOMEDIR/$user/conf/web/$domain.$WEB_SYSTEM.conf" ]; then
              cp $HOMEDIR/$user/conf/web/$domain.$WEB_SYSTEM.conf* conf/
          else
              # legacy format: all domain configs in single file
              tpl_file="$WEBTPL/$WEB_SYSTEM/$WEB_BACKEND/$TPL.tpl"
              conf="$HOMEDIR/$user/conf/web/$WEB_SYSTEM.conf"
              get_web_config_lines "$tpl_file" "$conf"
              sed -n "$top_line,$bottom_line p" $conf > conf/$WEB_SYSTEM.conf
          fi
          
          
# Backup ssl vhost
          if [ "$SSL" = 'yes' ]; then
              if [ -e "$HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.ssl.conf" ]; then
                  cp $HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.ssl.conf* conf/
              elif [ -e "$HOMEDIR/$user/conf/web/$domain.$WEB_SYSTEM.ssl.conf" ]; then
                  cp $HOMEDIR/$user/conf/web/$domain.$WEB_SYSTEM.ssl.conf* conf/
              else

This file has been truncated. show original

trogvar · November 19, 2022, 7:24am

Thanks! But this changes wil be erased by next update…
I think corresponding lines are:

github.com

hestiacp/hestiacp/blob/5965a75a54cb0a670b26d3329ca82628875033ae/bin/v-backup-user#L343-L355


      
          if [ $WEB_BACKEND == 'php-fpm' ]; then
              cp $HESTIA/data/templates/web/$WEB_SYSTEM/php-fpm/$TPL.tpl template/$WEB_SYSTEM/
              cp $HESTIA/data/templates/web/$WEB_SYSTEM/php-fpm/$TPL.stpl template/$WEB_SYSTEM/
              cp $HESTIA/data/templates/web/php-fpm/$BACKEND.tpl template/php-fpm/
          else
              cp $HESTIA/data/templates/web/$WEB_SYSTEM/$TPL.tpl template/$WEB_SYSTEM/
              cp $HESTIA/data/templates/web/$WEB_SYSTEM/$TPL.stpl template/$WEB_SYSTEM/
          fi
          if [ -n "$PROXY_SYSTEM" ] && [ -n "$PROXY" ]; then
              mkdir  template/$PROXY_SYSTEM
              cp $HESTIA/data/templates/web/$PROXY_SYSTEM/$PROXY.tpl template/$PROXY_SYSTEM/
              cp $HESTIA/data/templates/web/$PROXY_SYSTEM/$PROXY.stpl template/$PROXY_SYSTEM/
          fi

eris · November 19, 2022, 7:46am

If you open the tar file you should be able to copy the templates to /usr/local/hestia/data/templates

But it should be done by de user instead

trogvar · November 19, 2022, 7:58am

Oh, I see. Ok. Thanks!

jlguerrero · November 19, 2022, 8:20am

The thing here is that the user doesn’t care about nginx hosting and it’s templates but the sysadmin does.

The fact that they can be ported among servers is very helpful and removes a lot of pain.

eris · November 19, 2022, 8:21am

We don’t feel “conferrable” by just replacing/creating them on default but at least they can be restored in case of a major server breakdown…

jlguerrero · November 19, 2022, 9:37am

How about an option in the backend?

Yes, it may be overcomplicating things…

Raphael · November 19, 2022, 11:48am

I dont think it is worth the time, backups gets restored about 95% on cli using v-restore-user - expand the backup and restore documentation would probaly make more sense.

eris · November 19, 2022, 11:52am

Also if you need to import into a new server it needs to be done 100% via CLI

Deepak · November 25, 2022, 8:37am

Hello ScIT and Eris!

This was a part of my list after I began to use Hestia. Due to lack of time, I could not implement for me.

Packing of custom templates is implemented already .

The requested enhancement is a mere unpack and copy in the respective directory. If the custom templates are there, only then they will be used in the rebuild.

An experienced user, who knows of all these tips and tricks may be able to do this with one click. But for a starter, it would be a headache to first understand this problem.

And to have this tiniest little change would give some ease at the time of restore.

eris · November 25, 2022, 9:50am

It is currently not possible due to how things are written unless we rewrite it in a special way and probally not worth it.

We could offcouse copy them for now to the /root/restore/ folder and information about in the documentation

jlguerrero · November 25, 2022, 11:46am

Every step in this direction is very positive from my personal perspective.

system · December 25, 2022, 11:47am

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.