DROP DATABASE on restore (rebuild_mysql_database)

fra · September 5, 2022, 2:26pm

Hi, I checked the code, can be that when restoring a database (mysql in my case) it will not be dropped before recreating?

github.com

hestiacp/hestiacp/blob/5a0a002197eab45157784eaa4b8900bd5d32923f/bin/v-restore-user#L781


      
                  # Unzipping database dump
                  if [ $backup_mode = 'zstd' ]; then  
                      pzstd -d $tmpdir/db/$database/$database.*.sql.zst
                  else
                      gzip -d $tmpdir/db/$database/$database.*.sql.gz
                  fi
          
          
        # Importing database dump
                  database_dump="$tmpdir/db/$database/$database.$TYPE.sql"
                  case $TYPE in
                      mysql) rebuild_mysql_database;
                             import_mysql_database $database_dump ;;
                      pgsql) rebuild_pgsql_database;
                             import_pgsql_database $database_dump ;;
                  esac
              done
          fi
          
          
# Restoring cron jobs
          if [ "$cron" != 'no' ] && [ -n "$CRON_SYSTEM" ]; then
              echo -e  "\n-- CRON --" |tee -a $tmpdir/restore.log

DROP {DATABASE | SCHEMA} [IF EXISTS] db_name can be called

eris · September 5, 2022, 3:35pm

rebuild_mail_databse will only reset the username / password I think it doesn’t delete it.

So you are right please create an issue report at

fra · September 6, 2022, 5:11am

ok opened [Bug] DROP DATABASE before restoring a backup · Issue #2909 · hestiacp/hestiacp · GitHub