Hi.
I propose a small correction to the script: /usr/local/hestia/bin/v-add-firewall-chain. This script is called every time an IP is to be added to the banlist and checks if a given chain exists. If it does not exist, it adds it, but if it does, it still creates an entry in the logs: /usr/local/hestia/log/system.log that it has added it, although it is not true. This causes the entries about adding a chain to duplicate and the log file is practically twice as large.
I added an “else” entry in the section:
# Preserving chain
chains="$HESTIA/data/firewall/chains.conf"
check_chain=""
[ -f "$chains" ] && check_chain=$(grep "CHAIN='$chain'" "$chains")
if [ -z "$check_chain" ]; then
echo "CHAIN='$chain' PORT='$port' PROTOCOL='$protocol'" >> "$chains"
else
exit
fi
and the problem disappeared. Below is a fragment of the logs before and after adding the fix.
2025-02-04 09:02:56 v-add-firewall-ban '57.129.17.80' 'SSH'
2025-02-04 09:03:34 v-add-firewall-chain 'SSH'
2025-02-04 09:03:34 v-add-firewall-ban '51.159.91.86' 'SSH'
2025-02-04 09:04:45 v-add-firewall-chain 'SSH'
2025-02-04 09:04:45 v-add-firewall-ban '14.103.27.46' 'SSH'
2025-02-04 09:06:16 v-add-firewall-chain 'SSH'
2025-02-04 09:06:16 v-add-firewall-ban '159.13.21.246' 'SSH'
2025-02-04 09:06:18 v-add-firewall-chain 'SSH'
2025-02-04 09:06:18 v-add-firewall-ban '146.59.228.24' 'SSH'
2025-02-04 09:08:59 v-add-firewall-ban '134.122.45.95' 'SSH'
2025-02-04 09:09:11 v-add-firewall-ban '162.144.60.123' 'SSH'
2025-02-04 09:10:48 v-add-firewall-ban '140.246.193.16' 'SSH'
2025-02-04 09:11:12 v-add-firewall-ban '203.145.34.54' 'SSH'
2025-02-04 09:12:41 v-add-firewall-ban '142.4.1.40' 'SSH'
What do you think about this?